Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup_run_directory includes arguments that are either boolean or strings #134

Closed
navidcy opened this issue Mar 28, 2024 · 1 comment
Closed

Comments

@navidcy
Copy link
Contributor

navidcy commented Mar 28, 2024

The setup_run_directory method

def setup_run_directory(

uses surface_forcing argument that seems to take either False or a string, e.g., "era5".

This is prone for mistakes though since, at least myself, when I see a variable that can be False I assume it's a boolean so True or False are the only allowed values.

Originally posted by @navidcy in #95 (comment)

@navidcy
Copy link
Contributor Author

navidcy commented Apr 9, 2024

This was closed by #135

@navidcy navidcy closed this as completed Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant