Change default arg from False to None in the setup run dir #135
Conversation
Co-authored-by: Navid C. Constantinou <[email protected]>
| @@ -1470,14 +1470,15 @@ def setup_run_directory( | |||
| raise ValueError( | |||
| f"Cannot find the premade run directory files at \n{premade_rundir_path}\n. Something is not right about how the package has been installed as these files are missing!" | |||
| ) | |||
| if surface_forcing != False: | |||
| if type(surface_forcing) == str: | |||
There was a problem hiding this comment.
isinstance(surface_forcing, str)... or just if surface_forcing now, maybe use type hint of Optional[str] to suggest what is expected. Anyway, guess it's too late :)
There was a problem hiding this comment.
it's never too late, we can open another one ;)
There was a problem hiding this comment.
I don't understand your second suggestion, after "or just"... though
There was a problem hiding this comment.
oh... now I see... I didn't know that if x: would be triggered even if x is not a boolean or 1.
There was a problem hiding this comment.
In the context of Boolean operations, and also when expressions are used by control flow statements, the following values are interpreted as false: False, None, numeric zero of all types, and empty strings and containers (including strings, tuples, lists, dictionaries, sets and frozensets). All other values are interpreted as true.
From https://docs.python.org/3/reference/expressions.html#booleans
PR closes issue #134