Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS paper #100

Merged
merged 310 commits into from
Aug 9, 2024
Merged

JOSS paper #100

merged 310 commits into from
Aug 9, 2024

Conversation

navidcy
Copy link
Contributor

@navidcy navidcy commented Feb 16, 2024

Added the JOSS template. Let's work on this! 🎉

After every commit that modifies the paper.md markdown file a GitHub action is called that compiles the PDF version of the paper and commits it in the paper directory. See, e.g., 9ea312f.

@navidcy
Copy link
Contributor Author

navidcy commented Feb 19, 2024

Relevant discussion in #42

@ashjbarnes
Copy link
Collaborator

Is the workflow here to keep this PR open as we work on the paper together and merge when we're happy?

@navidcy
Copy link
Contributor Author

navidcy commented Feb 20, 2024

Yes, that's the idea. Keep the PR open, work on it, submit to JOSS (still the PR is open) and we merge only when it's accepted after the reviews etc.

paper/paper.md Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
@ashjbarnes
Copy link
Collaborator

Is there a good way to build / test locally? I keep pushing when the formatting breaks to test which seems inefficient!

@navidcy
Copy link
Contributor Author

navidcy commented Mar 28, 2024

Is there a good way to build / test locally? I keep pushing when the formatting breaks to test which seems inefficient!

Ignore the tests anyway. We are not changing any part of the code.

I don’t know the answer to your question. That’s how I was doing it other times. You can look into this in JOSS website but if it’s just so the “the tests don’t stop” I wouldn’t bother.

@ashjbarnes
Copy link
Collaborator

Order of authors wasn't meant to be a decision too btw I was just putting them on the paper

@ashjbarnes
Copy link
Collaborator

@dhruvbhagtani @ChrisC28 @reillyja @aekiss all contributors to the package on Github are welcome to contribute to the paper. Here's what we've got so far - any feedback or suggestions would be great :) Apparently a 2-3 page written report is normal for JOSS papers. We also need to make sure that the documentation / readthedocs page are in a good state for the reviewers too

@navidcy
Copy link
Contributor Author

navidcy commented Mar 28, 2024

@ashjbarnes could I make some edits and commit (instead of suggestions in the PR)? are you done for the moment?

@ashjbarnes
Copy link
Collaborator

@ashjbarnes could I make some edits and commit (instead of suggestions in the PR)? are you done for the moment?

Ok that was my last commit of some changes I'd made to incorporate your feedback. Go for it!

@navidcy
Copy link
Contributor Author

navidcy commented Mar 28, 2024

The caption of the figure insists not appearing... hm...

@dhruvbhagtani
Copy link
Member

The manuscript looks great! Suggesting some areas of discussion (please feel free to ignore any or all of them):

  1. It might be useful to have a figure explaining regional modelling like - downscaling from global to your region of interest that we can highlight (which can be Tasmania and we can then explain our example notebook as well, more on that below).
  2. I don't know if there are plans on this or not, but reading other papers in JOSS, I realised that having a more extensive example within the paper could be useful. We can use our Tassie example for this.

I can go through these example codes later in the week and make edits if needed.

@navidcy
Copy link
Contributor Author

navidcy commented Mar 29, 2024

I admit I haven't read the manuscript in detail yet. I'll do it today (not holiday in Cyprus) and will add comments or restructure a bit.

@navidcy
Copy link
Contributor Author

navidcy commented Mar 29, 2024

I also think that we should definitely mention https://gmd.copernicus.org/articles/16/1481/2023/

@article{polton2023reproducible,
    author  = {Polton, J. and Harle, J. and Holt, J. and Katavouta, A. and Partridge, D. and Jardine, J. and Wakelin, S. and Rulent, J. and Wise, A. and Hutchinson, K. and Byrne, D. and Bruciaferri, D. and O'Dea, E. and De Dominicis, M. and Mathiot, P. and Coward, A. and Yool, A. and Palmi\'eri, J. and Lessin, G. and Mayorga-Adame, C. G. and Le Guennec, V. and Arnold, A. and Rousset, C.},
    title   = {Reproducible and relocatable regional ocean modelling: fundamentals and practices},
    journal = {Geoscientific Model Development},
    volume  = {16},
    year    = {2023},
    number  = {5},
    pages   = {1481--1510},
    doi     = {10.5194/gmd-16-1481-2023}
}

@navidcy
Copy link
Contributor Author

navidcy commented Aug 9, 2024

congrats all!
paper is published

c00a5fe7-b0de-5bfa-5c31-e97085fe906f

@PaulSpence (left) handing the 2024 COSIMA Most Selfless Contributor Award to @ashjbarnes (right); July 1st, 2024, Canberra, Australia

@navidcy navidcy merged commit 4a863ad into main Aug 9, 2024
1 check passed
@navidcy navidcy deleted the joss-paper branch August 9, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants