Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use verbosely-silly names when creating data arrays for tests #133

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

navidcy
Copy link
Contributor

@navidcy navidcy commented Mar 27, 2024

This PR uses really silly names and adds a remark to avoid any confusion created, e.g., see #114.

Closes #114

@navidcy navidcy requested a review from ashjbarnes March 27, 2024 07:47
@navidcy navidcy changed the title Use verbosely-silly names Use verbosely-silly names when creating test data arrays Mar 27, 2024
@navidcy navidcy changed the title Use verbosely-silly names when creating test data arrays Use verbosely-silly names when creating data arrays for tests Mar 27, 2024
Copy link
Collaborator

@ashjbarnes ashjbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

silly_approve

@navidcy navidcy merged commit c2c6dda into main Mar 27, 2024
4 checks passed
@navidcy navidcy deleted the ncc/explain-silliness branch March 27, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deepness
2 participants