doc edits #154
Closed
doc edits #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you reopen this PR to |
navidcy
requested changes
Apr 22, 2024
There was a problem hiding this comment.
@aekiss these are great additions, but since they are not on the paper.md file we need to merge them on #main otherwise the changes will only appear only after JOSS paper is published. So if you could please, whenever you are done editing, open another PR from joss-paper-ak2 branch to main that'd be great!
navidcy
reviewed
Apr 22, 2024
navidcy
reviewed
Apr 22, 2024
| The `common_files` folder contains all of the required files for a regional MOM6 run, including a `data_table` with constant surface forcing as a placeholder. The other two directories offer different choices for the surface forcing, affecting the `data_table`. |
There was a problem hiding this comment.
Suggested change
| The `common_files` folder contains all of the required files for a regional MOM6 run, including a `data_table` with constant surface forcing as a placeholder. The other two directories offer different choices for the surface forcing, affecting the `data_table`. | |
| The `common_files` directory contains all of the required files for a regional MOM6 run, including a `data_table` with constant surface forcing as a placeholder. The other two directories offer different choices for the surface forcing, affecting the `data_table`. |
Co-authored-by: Navid C. Constantinou <[email protected]>
|
let me know when you are done editing in the |
Merged
|
I'm closing this. I opened #157 with all the changes you suggested here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.