Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show bathymetry plot in notebook + some other fixes #156

Merged
merged 12 commits into from
Apr 23, 2024
Merged

Conversation

navidcy
Copy link
Contributor

@navidcy navidcy commented Apr 22, 2024

@aekiss this PR adds the missing thumbnail.

It's not done in an automatic way, I just evaluated that particular cell.

Ideally, we need to resolve #119

Also some fixes in docstrings (eg rectangular_grid) and in the explanations in the demo notebooks.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@navidcy navidcy added the documentation 📔 Improvements or additions to documentation label Apr 22, 2024
@navidcy
Copy link
Contributor Author

navidcy commented Apr 22, 2024

Hm... OK, it's a failed attempt...

@navidcy
Copy link
Contributor Author

navidcy commented Apr 22, 2024

I think I fixed it! Could somebody review this?

@aekiss, here's a preview of the docs showing that the thumbnail is there!

@navidcy navidcy requested a review from angus-g April 22, 2024 17:08
Copy link
Collaborator

@angus-g angus-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description doesn't capture the fix to rectangular_hgrid. One small typo in your doc changes, otherwise I think they're fine.

I guess this just makes the thumbnails for both notebooks the same. I suppose there's no issue with that (it's better than nothing!)

@navidcy
Copy link
Contributor Author

navidcy commented Apr 23, 2024

With #59 one of the examples will go away anyway

@navidcy
Copy link
Contributor Author

navidcy commented Apr 23, 2024

PR description doesn't capture the fix to rectangular_hgrid.

That's a change only in the comments -- I'm adding a remark

@navidcy navidcy merged commit e02092a into main Apr 23, 2024
5 checks passed
@navidcy navidcy deleted the ncc/fixes-in-demos branch April 23, 2024 03:13
@angus-g
Copy link
Collaborator

angus-g commented Apr 23, 2024

PR description doesn't capture the fix to rectangular_hgrid.

That's a change only in the comments -- I'm adding a remark

There was also an addition of deg2rad, no?

@navidcy
Copy link
Contributor Author

navidcy commented Apr 23, 2024

In a comment tho, not in source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📔 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing the demo notebooks using the docker image locally
2 participants