Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make setup rundir more robust take #2 #179

Merged
merged 4 commits into from
Jul 1, 2024
Merged

Conversation

ashjbarnes
Copy link
Collaborator

This is a clone of #177 with three cherry picked commits. The other PR got really messy as @angus-g needed to handle the update to numpy 2 in between

@angus-g
Copy link
Collaborator

angus-g commented Jul 1, 2024

There's nothing wrong with force pushing to your PR branches. You could've essentially just pushed this branch to the one for #177. :)

@ashjbarnes
Copy link
Collaborator Author

In this PR I gave up on changing structure to move the demos folder to regional-mom6, because it required altering the pyproject.toml and then troubleshooting the github workflow file. To implement this in line wiht conda guidelines (see Angus' comment ) this will take a bit more fiddling around, and another PR.

What we have in this PR means that there's extra error handling when the CPU layout isn't provided, and the setup_rundir function looks at the package root folder for the premade_run_directories if it can't find the folder where it expects it, in the case that the user is being lazy and importing it directly for development purposes.

@navidcy navidcy changed the title [DUPLICATED] Make setup rundir more robust Make setup rundir more robust take #2 Jul 1, 2024
@navidcy navidcy merged commit 26ff5fc into main Jul 1, 2024
6 checks passed
@navidcy navidcy deleted the setup_rundir_update_v2 branch July 1, 2024 23:22
@ashjbarnes
Copy link
Collaborator Author

There's nothing wrong with force pushing to your PR branches. You could've essentially just pushed this branch to the one for #177. :)

Oh thanks good to know! I thought I'd made a huge mess of the other one by force pushing like 4 times either side of your numpy PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants