Fix NaN interpolation to catch edge cases and remove time dimension
#35
Conversation
|
Ok I ran black and then pushed again but the test fails and idk why |
|
OK! I think you have some WEIRD characters at the end of your file! |
|
I think it originated because you had a parsing error with 2 parentheses in your first commit.... |
mom6_regional/mom6_regional.py
Outdated
| @@ -1503,3 +1457,4 @@ def brushcut(self, ryf=False): | |||
| ) | |||
|
|
|||
| return segment_out, encoding_dict | |||
There was a problem hiding this comment.
There were some WEIRD characters here. If I opened with VS Code look what I saw:
There was a problem hiding this comment.
Yeah I saw that and thought I fixed it with the second commit. That's not present in my local copy (black actually ran fine for me) but maybe I forgot to save and commit again. Just re-committed now
navidcy
changed the title
NaN interpolation to catch edge cases and remove time dimension
|
That's good... |
|
Gotcha! |
|
Note: If this was part of dealing with #34 then just feel free to commit there. :) |
Codecov Report
@@ Coverage Diff @@
## main #35 +/- ##
========================================
+ Coverage 8.66% 8.81% +0.15%
========================================
Files 2 2
Lines 450 431 -19
========================================
- Hits 39 38 -1
+ Misses 411 393 -18
|
This fixes a few headaches in the initial condition interpolater. These are important for running with a newer executable where more netcdf variable type checks are done