Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions for local docs built #49

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Conversation

navidcy
Copy link
Contributor

@navidcy navidcy commented Jun 22, 2023

Closes #48

@navidcy navidcy added the documentation 📔 Improvements or additions to documentation label Jun 22, 2023
@navidcy navidcy requested a review from angus-g June 22, 2023 07:40
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #49 (09bc56c) into main (2da3e29) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #49   +/-   ##
=======================================
  Coverage   10.72%   10.72%           
=======================================
  Files           2        2           
  Lines         429      429           
=======================================
  Hits           46       46           
  Misses        383      383           

docs/contributing.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@angus-g angus-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright now. I assume you've tested the conda instructions.

@navidcy
Copy link
Contributor Author

navidcy commented Jun 22, 2023

Yeap, I'd done that ;)

@navidcy navidcy merged commit abf630d into main Jun 22, 2023
@navidcy navidcy deleted the ncc/docs-local-api branch June 22, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📔 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local docs don't see the package itself?
2 participants