Test hgrid generator #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
==========================================
+ Coverage 13.75% 15.61% +1.86%
==========================================
Files 2 2
Lines 429 429
==========================================
+ Hits 59 67 +8
+ Misses 370 362 -8 ☔ View full report in Codecov by Sentry. |
navidcy
reviewed
Sep 4, 2023
navidcy
requested changes
Sep 4, 2023
tests/test_grid_generation.py
Outdated
| ], | ||
| ) | ||
| def test_rectangular_hgrid(lat, lon): | ||
| rectangular_hgrid(lat, lon) |
There was a problem hiding this comment.
can we check that the output is an xarray dataset?
Co-authored-by: Navid C. Constantinou <[email protected]>
navidcy
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added simple rectangular_hgrid test function