Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify angle_between + refactor quadrilateral_area #65

Merged
merged 25 commits into from
Sep 6, 2023
Merged

Simplify angle_between + refactor quadrilateral_area #65

merged 25 commits into from
Sep 6, 2023

Commits on Sep 5, 2023

  1. simplify angle_between

    @navidcy
    navidcy committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    ea9bbbe View commit details
    Browse the repository at this point in the history

  2. black format

    @navidcy
    navidcy committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    812a302 View commit details
    Browse the repository at this point in the history

  3. remove random unit vector; add 2 more tests

    @navidcy
    navidcy committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    3d3179a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into ncc/simplify-angle-between

    @navidcy
    navidcy authored Sep 5, 2023
    Configuration menu
    Copy the full SHA
    a8c9ad4 View commit details
    Browse the repository at this point in the history

  5. refactor quadrilateral_area

    @navidcy
    navidcy committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    6721c47 View commit details
    Browse the repository at this point in the history

  6. black format

    @navidcy
    navidcy committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    d414ea1 View commit details
    Browse the repository at this point in the history

  7. merge main

    @navidcy
    navidcy committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    30254bd View commit details
    Browse the repository at this point in the history

  8. adds comment

    @navidcy
    navidcy committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    9ad060e View commit details
    Browse the repository at this point in the history

  9. better docstring for quadilateral_areas

    @navidcy
    navidcy committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    ad69968 View commit details
    Browse the repository at this point in the history

  10. add test for quadilateral_area

    @navidcy
    navidcy committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    d34d2f8 View commit details
    Browse the repository at this point in the history

  11. add latlon_to_cartesian + test

    @navidcy
    navidcy committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    283778a View commit details
    Browse the repository at this point in the history

  12. one more test for quadilateral_area

    @navidcy
    navidcy committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    4cf6a3b View commit details
    Browse the repository at this point in the history

  13. remove debuggint print statements

    @navidcy
    navidcy committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    d4f8668 View commit details
    Browse the repository at this point in the history

  14. cleaner test_quadilateral_areas

    @navidcy
    navidcy committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    2366869 View commit details
    Browse the repository at this point in the history

  15. add clarification in latlon_to_cartesian doc

    @navidcy
    navidcy committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    b5877f3 View commit details
    Browse the repository at this point in the history

  16. add clarification in latlon_to_cartesian doc

    @navidcy
    navidcy committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    00ad0b5 View commit details
    Browse the repository at this point in the history

  17. add clarification in angle_between docs

    @navidcy
    navidcy committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    2ee793d View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. latlon_to_cartesian, quadilateral_area(s) now know R

    @navidcy
    navidcy committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    d091f32 View commit details
    Browse the repository at this point in the history

  2. black formating

    @navidcy
    navidcy committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    a18ff47 View commit details
    Browse the repository at this point in the history

  3. correct phrasing in docstring

    @navidcy
    navidcy committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    3147a51 View commit details
    Browse the repository at this point in the history

  4. better exception error

    @navidcy
    navidcy committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    139ac70 View commit details
    Browse the repository at this point in the history

  5. test the exception error by quadilateral_area

    @navidcy
    navidcy committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    aa5ed7a View commit details
    Browse the repository at this point in the history

  6. Exception -> ValueError

    @navidcy
    navidcy committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    c423f52 View commit details
    Browse the repository at this point in the history

  7. Implement quadrilateral_areas using broadcasting 

    We need to define a vecdot function (which is available in the Array
API but not the main numpy API, sadly), which will compute the dot
product of the last axis of two arrays.
    @angus-g
    angus-g committed Sep 6, 2023
    1 Configuration menu
    Copy the full SHA
    dccdede View commit details
    Browse the repository at this point in the history

  8. Fix quadrilateral area exception test

    @angus-g
    angus-g committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    8d45e19 View commit details
    Browse the repository at this point in the history