Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input parameter check & Error message modification #11

Closed
wants to merge 2 commits into from
Closed

Input parameter check & Error message modification #11

wants to merge 2 commits into from

Conversation

amberbhardwaj
Copy link
Contributor

Added functionality to check input parameter
Deleted wrong error messages
Added the error messages to debug properly
Added return value to a non-void number

Added additional information about how to enable syslog feature properly.
If still facing issue while capturing syslogs through client (e.g. dlt_viewer) after following given steps then install listed packages:
build-essential
build-essential checkinstall
pkg-config libsystemd-journal-dev

Note:
It's is a known issue when you try to capture syslog via dlt_viewer then syslogs wouldn't come in dlt_viewer because of improper configuration (won't route the log to port 47111) of dlt-system.
Added functionality to check input parameter
Deleted wrong error messages
Added the error messages to debug properly
Added retrun value to a non-void number

Signed-off-by: amberbhardwaj <[email protected]>
@clipka
Copy link
Contributor

clipka commented May 16, 2017

Could you please add a signed-off entry to your patch? Thanks.

@amberbhardwaj
Copy link
Contributor Author

amberbhardwaj commented May 16, 2017

Hello @clipka ,

I submitted a patch(Added Description in dlt-system.conf with commit ID - 0a054fb) before this patch, in that patch i forgot to add sign-off. So someone merged my patch without sign-off. Thus this time, i have submitted patch for another feature with sign-off information. Below you can see the title of patch and description:
{
Input parameter check & Error message modification
Added functionality to check input parameter
Deleted wrong error messages
Added the error messages to debug properly
Added return value to a non-void number

Signed-off-by: amberbhardwaj <[email protected]>

}

Please let me know if issue with my new patch so that i can modify ASAP.

@amberbhardwaj
Copy link
Contributor Author

I am pushing another patch and removing this patch because this patch is showing older changes which have already merged in Genivi DLT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants