logfile: exhance internal dlt logging by introducing size limits #369
Conversation
danielweber2018
force-pushed
the
dlt_logging_size_limits
branch
from
52067d4
to
978464e
Compare
|
Hello @danielweber2018 |
|
Hi @minminlittleshrimp Maybe for a short explanation of my changes: I haven't maintained the PR (e.g. the new conflicts), but if there is interest in this PR I'll be happy to take care of it. If you have any questions, please contact me. Thanks and regards Daniel |
|
Hello @danielweber2018 |
Enhance dlt logging such that multiple files are used as it is done for the offline traces. Add limit-specific config values for logging. For this purpose the pattern of index-based file names is used only. This approach of logging to multiple files and rotating in order to keep the limits ensures that dlt logs take care of available space on the underlying file system and do not grow infinitely. Signed-off-by: Daniel Weber <[email protected]> Co-authored-by: Oleg Tropmann <[email protected]>
danielweber2018
force-pushed
the
dlt_logging_size_limits
branch
from
978464e
to
1d9262e
Compare
|
I rebased my PR to the current master and resolved all conflicts. Additionally i simplified the PR via the removing of the split between dlt_common and dlt_log (like requests from michael methner). |
| const int file_size = 256; | ||
| const int max_file_size = 512; | ||
|
|
||
| const char* log1 = "ONE\n"; |
There was a problem hiding this comment.
Hello @danielweber2018
Build logs show me:
Scanning dependencies of target gtest_dlt_daemon_multiple_files_logging
[ 86%] Building CXX object tests/CMakeFiles/gtest_dlt_daemon_multiple_files_logging.dir/gtest_dlt_daemon_multiple_files_logging.cpp.o
/home/lum3hc/work/github/PR442/dlt-daemon/tests/gtest_dlt_daemon_multiple_files_logging.cpp: In member function ‘virtual void t_dlt_logging_multiple_files_append_reinit_normal_Test::TestBody()’:
/home/lum3hc/work/github/PR442/dlt-daemon/tests/gtest_dlt_daemon_multiple_files_logging.cpp:106:28: warning: format not a string literal and no format arguments [-Wformat-security]
dlt_vlog(LOG_INFO, log1);
^
/home/lum3hc/work/github/PR442/dlt-daemon/tests/gtest_dlt_daemon_multiple_files_logging.cpp:110:28: warning: format not a string literal and no format arguments [-Wformat-security]
dlt_vlog(LOG_INFO, log2);
^
[ 87%] Linking CXX executable gtest_dlt_daemon_multiple_files_logging
Could you please consider to use string literal format?
Maybe char array?
There was a problem hiding this comment.
Resolved with #481
|
|
||
| /* open DLT output file */ | ||
| errno = 0; | ||
| files_buffer->ohandle = open(file_path, O_WRONLY | O_APPEND, S_IRUSR | S_IWUSR | |
There was a problem hiding this comment.
Hello @danielweber2018
I would like to remove the superfluous mode bits with PR: #462
Thank you
Enhance dlt logging such that multiple files are used as it is done
for the offline traces. Add limit-specific config values for logging.
For this purpose the pattern of index-based file names is used only.
This approach of logging to multiple files and rotating in order
to keep the limits ensures that dlt logs take care of available
space on the underlying file system and do not grow infinitely.
The program was tested solely for our own use cases, which might differ from yours.
Licensed under Mozilla Public License Version 2.0
Daniel Weber, [email protected], Daimler TSS GmbH, imprint