Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filetransfer: fix filesize divisible by blocksize case #383

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

danielweber2018
Copy link
Contributor

@danielweber2018 danielweber2018 commented May 25, 2022

If the file size is divisible by the package size don't send one empty FLDA.
Also we send the correct number of FLDAs too.

The program was tested solely for our own use cases, which might differ from yours.
Licensed under Mozilla Public License Version 2.0

Daniel Weber, [email protected], Mercedes-Benz Technology Innovation GmbH, imprint

If the file size is divisible by the package size
don't send one empty FLDA.
Also we send the correct number of FLDAs too.

Signed-off-by: Daniel Weber <[email protected]>
@lti9hc
Copy link
Collaborator

lti9hc commented Dec 1, 2022

Hello @danielweber2018,
I have verified your change with files which are block aligned and are not block aligned, block size here is 1024.
Both of files were transfer successful with complete status
Thank you,

@thanhbnq
Copy link
Collaborator

thanhbnq commented Dec 1, 2022

Thanks @danielweber2018 for PR and @lti9hc for verification.

@thanhbnq thanhbnq merged commit 4857ffc into COVESA:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants