gateway: Fix Node handling and ECUid checks #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reset Receiver at connection close to prevent corruption Prevent out of bounds reads Fix connection select when processing passive node messages Signed-off-by: Andrei-Mircea Rusu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset Receiver at connection close to prevent corruption: a partial log may be received from a Node, but in case there is an ECUid mismatch, the socket will be closed and that log will never be completed corrupting the receiver.
Prevent out of bounds reads
Fix connection select when processing passive node messages: fd's can use the same value for a new connection if a previous connection is closed so we need to also select based on connection status
Signed-off-by: Andrei-Mircea Rusu [email protected]