Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log-level-config: add option to configure log levels #474

Merged
merged 1 commit into from
May 24, 2023

Conversation

alexmohr
Copy link
Contributor

The default log level can now be overwritten with
a different level stored in a configuration file.
Levels can be set for all ctid's of an apid
or only selected ctids

The program was tested solely for our own use cases, which might differ from yours.
Licensed under Mozilla Public License Version 2.0

Alexander Mohr, [email protected], Mercedes-Benz Tech Innovation GmbH, imprint

@lti9hc
Copy link
Collaborator

lti9hc commented May 15, 2023

Hello @alexmohr,
Currently, dlt-daemon was failed with unknown option, because you forgot to add definition DLT_LOG_LEVEL_APP_CONFIG in CMakeList file

You should add it below codes in dlt-daemon/CMakeLists.txt
if (WITH_LOG_LEVEL_APP_CONFIG)
add_definitions(-DDLT_LOG_LEVEL_APP_CONFIG)
endif()

@alexmohr
Copy link
Contributor Author

Hello @alexmohr, Currently, dlt-daemon was failed with unknown option, because you forgot to add definition DLT_LOG_LEVEL_APP_CONFIG in CMakeList file

You should add it below codes in dlt-daemon/CMakeLists.txt if (WITH_LOG_LEVEL_APP_CONFIG) add_definitions(-DDLT_LOG_LEVEL_APP_CONFIG) endif()

fixed 👍

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@alexmohr alexmohr force-pushed the log-level-config branch 3 times, most recently from 5bc73b7 to 5f1aef6 Compare May 17, 2023 14:45
@lti9hc
Copy link
Collaborator

lti9hc commented May 22, 2023

Hello @alexmohr,
Thanks for your contribution an interesting PR.
I have tested this PR on my local environment. The result was good.

@michael-methner or @lvklevankhanh could merge this PR
Thank you!

@alexmohr alexmohr force-pushed the log-level-config branch 2 times, most recently from 4dda234 to acf080b Compare May 23, 2023 08:29
The default log level can now be overwritten with
a different level stored in a configuration file.
Levels can be set for all ctid's of an apid
or only selected ctids

Signed-off-by: Alexander Mohr <[email protected]>
@michael-methner michael-methner merged commit 6aa89c7 into COVESA:master May 24, 2023
@michael-methner
Copy link
Collaborator

Hello @alexmohr ,
thank you very much for the rework. PR is merged 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants