Daemon connection handling fixes #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It might happen that an event is part of the epoll event queue that belongs to a connection which was destroyed before the event is handled. Due to this, the event handling main loop might stop and the daemon exits. This misbehavior is fixed with this patch. Signed-off-by: Christoph Lipka <[email protected]>
In dlt_daemon_send_all_multiple, if the connection was broken, we closed it before getting the next available connection. This must be avoided by having a temporary next pointer. The same kind of problem is valid for pointers coming from the epoll interface. The kernel can provide back connection pointer that are not valid any longer. Therefore, we need to use an ID instead of the pointer value to retrieve the connections. Signed-off-by: Frederic Berat <[email protected]> Signed-off-by: Christoph Lipka <[email protected]>
ssugiura
pushed a commit
that referenced
this pull request
Jul 6, 2020
now you can do make test after make :)
=== Sample build and test:
$ cmake -Bbuild -H. \
-DDLT_IPC=UNIX_SOCKET \
-DWITH_DLT_ADAPTOR=ON \
-DWITH_DLT_UNIT_TESTS=ON \
-DWITH_DLT_CXX11_EXT=ON \
-DWITH_DLT_MONITOR=OFF \
-DWITH_DLT_USE_IPv6=OFF
$ cd build
$ make
$ make test
Running tests...
Test project /home/fherrmann/git/dlt-daemon/build
Start 1: gtest_dlt_common
1/5 Test #1: gtest_dlt_common ................. Passed 0.02 sec
Start 2: gtest_dlt_user
2/5 Test #2: gtest_dlt_user ................... Passed 1.01 sec
Start 3: gtest_dlt_daemon_common
3/5 Test #3: gtest_dlt_daemon_common .......... Passed 0.01 sec
Start 4: dlt_env_ll_unit_test
4/5 Test #4: dlt_env_ll_unit_test ............. Passed 0.04 sec
Start 5: gtest_dlt_daemon_event_handler
5/5 Test #5: gtest_dlt_daemon_event_handler ... Passed 1.01 sec
100% tests passed, 0 tests failed out of 5
Total Test time (real) = 2.09 sec
===
Signed-off-by: Felix Herrmann <[email protected]>
Signed-off-by: KHANH LUONG HONG DUY <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If connection to e.g. DLT Viewer is established/removed very frequently, a memory violation might happen due to a bug in connection handling.