Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure for negative filter logstorage #557

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

minminlittleshrimp
Copy link
Collaborator

Upstream negative filter proprietary

Add 2 optional fields for excluded applications and contexts
Store value of these fields from config file

Signed-off-by: Le Tin <[email protected]>

Filter message base on excluded applications and contexts

Logstorage does not support both multiple excluded applications and contexts

Check applications and contexts from message, if they existed in excluded list
the message will be not stored in logstorage buffer

Signed-off-by: Le Tin <[email protected]>

Unit test update for negative filter

+ Add test suites for new functions
+ Add test cases for modification in current implementation
+ Update bash script for offline logstorage test

Signed-off-by: LUU QUANG MINH <[email protected]>

Update documentation to introduce negative filter

+ Add sequence diagram for negative filter
+ Add activity datagram for negative filter
+ Write description for negative filter in logstorage documentation
+ Write guideline for using negative filtern

Signed-off-by: LUU QUANG MINH <[email protected]>

Improvement for negative filter unit test

+ Add strncmp for checking success id storing process
+ Add comments for calloc functions to initialize config pointer

Signed-off-by: LUU QUANG MINH <[email protected]>

Initialize pointers in test suites

+ Add 3 more test scenarios for negative filter
+ Set unused excluded_apid/ctids fields to NULL

Signed-off-by: LUU QUANG MINH <[email protected]>
@minminlittleshrimp
Copy link
Collaborator Author

minminlittleshrimp commented Nov 19, 2023

OSS duplicated PR from contributor: #547
This is the upstream proprietary from DLT.

@minminlittleshrimp minminlittleshrimp mentioned this pull request Nov 19, 2023
@minminlittleshrimp minminlittleshrimp self-assigned this Dec 4, 2023
@minminlittleshrimp minminlittleshrimp merged commit 2118762 into COVESA:master Dec 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants