filetransferplugin: Present save popup once #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plugin's save command created a window for every successful or
erroneous attempt to save individual files selected.
This is tedious for more than a few files.
Instead, collect errors and present a single pop-up window.
In the future, an alternative might be to configure a selection between
this behaviour and a brief message in the status bar.
Fixes a bug where doFLDA was erroneously called on messages ending a
transfer ("FLFI..."), causing completed status for a file to be
incorrect and display inconsistently.
Adds FiletransferPlugin::doFLFI which emits a new signal so that
Form::finishfile_slot can record completion properly and auto-save if
needed. updatefile_slot now tracks received packages and completion is
ONLY recorded if a FLFI message is present.
Signed-off-by: Michael Foukarakis <[email protected]>
|
@mfukar Is it possible to add a signed off statement? |
|
@mfukar Oh sorry i have overseen, you have already done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin's save command created a window for every successful or erroneous attempt to save individual files selected. This is tedious for more than a few files.
Instead, collect errors and present a single pop-up window.
In the future, an alternative might be to configure a selection between this behaviour and a brief message in the status bar.
Fixes a bug where doFLDA was erroneously called on messages ending a transfer ("FLFI..."), causing completed status for a file to be incorrect and display inconsistently.
Adds FiletransferPlugin::doFLFI which emits a new signal so that Form::finishfile_slot can record completion properly and auto-save if needed. updatefile_slot now tracks received packages and completion is ONLY recorded if a FLFI message is present.