Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert Rename of dlt_common. (#512)" #513

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Revert "Revert Rename of dlt_common. (#512)" #513

wants to merge 2 commits into from

Conversation

LocutusOfBorg
Copy link
Contributor

This reverts commit a3ad76c.

@LocutusOfBorg
Copy link
Contributor Author

reopened

@alexmucde
Copy link
Collaborator

Thanks, i reverted already with this PR #512

@LocutusOfBorg
Copy link
Contributor Author

So, can you please explain what broke? We should really convert it into a c++ file, if containing c++ code, right?

@alexmucde
Copy link
Collaborator

@LocutusOfBorg Sorry i have not much tiem at the moment. The Windows build was not working, thats why i have reverted it. If you can also have a look into Windows would be nice.

@alexmucde alexmucde added this to the Release v2.27.0 milestone Aug 14, 2024
@LocutusOfBorg
Copy link
Contributor Author

@alexmucde does the pipeline have some link? I don't have any windows machine, nor I know how to build, but if the pipeline runs on GitHub I can try to fix...

@alexmucde alexmucde self-assigned this Sep 9, 2024
@LocutusOfBorg
Copy link
Contributor Author

@alexmucde can you please try this solution instead? It fixes the build for me

@alexmucde
Copy link
Collaborator

@LocutusOfBorg I get the following error:

Bibliothek "..\release\qdlt.lib" und Objekt "..\release\qdlt.exp" werden erstellt.
qdltoptmanager.obj : error LNK2019: Verweis auf nicht aufgel”stes externes Symbol "__imp_GetWindowThreadProcessId" in Funktion ""public: void __cdecl QDltOptManager::parse(class QStringList *)" (?parse@QDltOptManager@@QEAAXPEAVQStringList@@@z)".
..\release\qdlt.dll : fatal error LNK1120: 1 nicht aufgel”ste Externe

@alexmucde alexmucde self-requested a review October 14, 2024 14:52
@alexmucde
Copy link
Collaborator

The following line is missing in qdlt.pro:

win32:LIBS += User32.lib

This is already integrated in the master.

@LocutusOfBorg
Copy link
Contributor Author

is it ok now? I did sync master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmucde alexmucde Awaiting requested review from alexmucde

Assignees

@alexmucde alexmucde

Labels
enhancement
Projects
COVESA DLT Viewer
Status: ToDo
Milestone
Release v2.27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@LocutusOfBorg @alexmucde