Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support Windows file URI #7

Merged
merged 3 commits into from
Apr 28, 2021
Merged

fix: support Windows file URI #7

merged 3 commits into from
Apr 28, 2021

Conversation

maximlt
Copy link
Collaborator

@maximlt maximlt commented Apr 20, 2021

After CS-SI/eodag#244 an EOProduct has its location attribute that is a correct file URI path on Windows.

@maximlt
Copy link
Collaborator Author

maximlt commented Apr 20, 2021

Just realized this is to the master branch. @sbrunato could you add develop here too or should it submit it on the GitLab instance?

@sbrunato sbrunato changed the base branch from master to develop April 27, 2021 15:05
@sbrunato sbrunato merged commit 7c2e587 into develop Apr 28, 2021
@sbrunato sbrunato deleted the fix-uri-windows branch April 30, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunato sbrunato sbrunato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maximlt @sbrunato