This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Download procedure more consistent with EODAG itself #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunato
force-pushed
the
fix-output-paths
branch
from
4c405ce
to
d55df44
Compare
sbrunato
force-pushed
the
fix-output-paths
branch
from
d55df44
to
acefe1c
Compare
sbrunato
approved these changes
Apr 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10
@sbrunato I've decided to use
_prepare_downloadand_finalizefrom EODAG (base download plugin) here to help synchonizing the behaviour of this plugin with EODAG itself. Instead of having the plugin inherit fromDownload, I created a simple class that would inherit from it and would also save the status of each product before and after being downloaded. Let me know what you think about this approach :)If it's fine for you, it would make sense to turn
_prepare_downloadand_finalizeinto public methods, or to create utilities in EODAG (functions) so that they can be reused by the plugins directly without having to inherit fromDownload.I've also added the same test I recently added in EODAG for PEPS, i.e. a rather complete integration test. I just run it with (with the dev version of EODAG) and it run fine.
One thing that could be improved to make this plugin even closer to EODAG would be to handle product ordering. I believe
sentinelsatprovides everything we need to replicate what we do (waitandtimeout).