Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: server-mode streamed downloads for more plugins #778

Closed
wants to merge 1 commit into from
Closed

feat: server-mode streamed downloads for more plugins #778

wants to merge 1 commit into from

Conversation

sbrunato
Copy link
Collaborator

Remaining refactoring following #742

  • Refactor and cleanup unnecessary remaining code
  • Refactor and implement download streaming for AwsDownload on the same model as HTTPDownload
  • Refactor and implement download streaming for S3RestDownload on the same model as HTTPDownload

@sbrunato sbrunato marked this pull request as draft July 28, 2023 09:24
@github-actions
Copy link
Contributor

Test Results

       4 files  ±0         4 suites  ±0   4m 45s ⏱️ +30s
   394 tests ±0     392 ✔️ ±0    2 💤 ±0  0 ❌ ±0 
1 576 runs  ±0  1 516 ✔️ ±0  60 💤 ±0  0 ❌ ±0 

Results for commit b594dc9. ± Comparison against base commit 6cc222a.

@github-actions
Copy link
Contributor

Code Coverage (Ubuntu)

File Coverage
All files 81% ✅

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against b594dc9

@github-actions
Copy link
Contributor

Code Coverage (Windows)

File Coverage
All files 75% ✅

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against b594dc9

@sbrunato
Copy link
Collaborator Author

AwsDownload streaming implemented in #997

@sbrunato sbrunato closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sbrunato