Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump react-scripts from 4.0.3 to 5.0.0 #590

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 20, 2021

Bumps react-scripts from 4.0.3 to 5.0.0.

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the npm dependencies npm dependencies label Dec 20, 2021
@hannyle
Copy link
Contributor

hannyle commented Dec 22, 2021

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/develop/react-scripts-5.0.0 branch 8 times, most recently from 203af5b to 256bf76 Compare December 29, 2021 07:33
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/develop/react-scripts-5.0.0 branch 6 times, most recently from ec9bf6c to d57294b Compare January 3, 2022 06:45
@saulipurhonen
Copy link
Contributor

Depencies to install manually:
eslint-plugin-react
eslint-plugin-react-hooks

We might need to extend webpack configuration because CRA uses webpack 5 and it seems to have problems at least with json-schema-ref-parser package. Error message suggests to add a polyfill.
See React App Rewired addon

Also we need to convert logo SVG properties to camelCase, for example: xmlns:dc > xmlnsDc

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/develop/react-scripts-5.0.0 branch from d57294b to 4a9851a Compare January 20, 2022 14:03
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/develop/react-scripts-5.0.0 branch 6 times, most recently from 173e3e6 to 8047e01 Compare February 2, 2022 07:50
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/develop/react-scripts-5.0.0 branch 2 times, most recently from e1f7441 to 8797675 Compare February 9, 2022 04:42
@saulipurhonen
Copy link
Contributor

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 9, 2022

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@saulipurhonen
Copy link
Contributor

@dependabot recreate

Bumps [react-scripts](https://github.com/facebook/create-react-app/tree/HEAD/packages/react-scripts) from 4.0.3 to 5.0.0.
- [Release notes](https://github.com/facebook/create-react-app/releases)
- [Changelog](https://github.com/facebook/create-react-app/blob/main/CHANGELOG.md)
- [Commits](https://github.com/facebook/create-react-app/commits/[email protected]/packages/react-scripts)

---
updated-dependencies:
- dependency-name: react-scripts
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/develop/react-scripts-5.0.0 branch from b5e7ad4 to bd9aa95 Compare February 9, 2022 08:29
@saulipurhonen
Copy link
Contributor

I think we need to wait for json-schema-ref-parser package to release new update regarding Webpack 5 upgrade. See APIDevTools/json-schema-ref-parser#254
headlamp-k8s/headlamp#405

It seems that rewiring Webpack configuration with Create React App isn't very straightforward and while some 3rd party libraries could work, I'd like to solve this with waiting for an official fix.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 1, 2022

A newer version of react-scripts exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@blankdots
Copy link
Contributor

@dependabot recreate

Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 4, 2024

Superseded by #941.

@dependabot dependabot bot closed this Mar 4, 2024
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/develop/react-scripts-5.0.0 branch March 4, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
npm dependencies npm dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants