-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Fiona to v1.9 #256
Update Fiona to v1.9 #256
Conversation
The present failures are due to service issues with our THREDDS server. Should I make these tests |
Use mamba-org/provision-with-micromamba Action with caching
The error I'm seeing has to do with cf-xarray: |
The THREDDS issues have been resolved, cf-xarray fixes are on the way: xarray-contrib/cf-xarray#415. (EDIT: the bad cf-xarray version has just been yanked. Will perform a re-run of tests - should pass now). I'm wondering though if we should allow the THREDDS-related tests to fail since they're service-dependent. What do you think? |
Is there a way to fail only if the service is not on ? If the service is available, but the test fails, I'd like to catch that. |
I can definitely look into that. If it's simple enough that I can add it here this morning, I'll add it. Otherwise, no more changes. As it stands, though, am I good to merge? |
Failing because of a new |
Update black
Fiona v1.9 has API changes that necessitate changes on our end. This will render us more in line with Fiona v2.0 when it is soon released. The primary change is that Fiona features are now their own class
fiona.Feature
containingfiona.Geometry
classes. These are compatible withdict()
outputs, so no changes should be needed inRaven-WPS
.For more information, see: Toblerity/Fiona#787
Changes
pip
was comparing compatible versions ofsphinx_rtd_theme
, so this has now been set a>=1.0
.Fiona.write
is now used for writing output file JSONs.Additonal Notes
The conda package is not yet released due to a few small changes needed in their testing suite. This should be addressed soon. See: conda-forge/fiona-feedstock#208- This has been released on conda-forge.