Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fiona to v1.9 #256

Merged
merged 11 commits into from
Feb 1, 2023
Merged

Update Fiona to v1.9 #256

merged 11 commits into from
Feb 1, 2023

Conversation

Zeitsperre
Copy link
Member

@Zeitsperre Zeitsperre commented Jan 30, 2023

Fiona v1.9 has API changes that necessitate changes on our end. This will render us more in line with Fiona v2.0 when it is soon released. The primary change is that Fiona features are now their own class fiona.Feature containing fiona.Geometry classes. These are compatible with dict() outputs, so no changes should be needed in Raven-WPS.

For more information, see: Toblerity/Fiona#787

Changes

  • Set minimum GDAL version at 3.1
  • pip was comparing compatible versions of sphinx_rtd_theme, so this has now been set a >=1.0.
  • The new Fiona API is now used for vector reprojection. Fiona.write is now used for writing output file JSONs.

Additonal Notes

The conda package is not yet released due to a few small changes needed in their testing suite. This should be addressed soon. See: conda-forge/fiona-feedstock#208 - This has been released on conda-forge.

@Zeitsperre Zeitsperre added the enhancement New feature or request label Jan 30, 2023
@Zeitsperre Zeitsperre requested a review from huard January 30, 2023 22:18
@Zeitsperre Zeitsperre self-assigned this Jan 30, 2023
Base automatically changed from pre-commit-ci-update-config to master January 31, 2023 00:09
@Zeitsperre
Copy link
Member Author

@huard

The present failures are due to service issues with our THREDDS server. Should I make these tests XFAILable?

@huard
Copy link
Collaborator

huard commented Jan 31, 2023

The error I'm seeing has to do with cf-xarray:
No such file or directory: '/home/runner/work/RavenPy/RavenPy/.tox/py38/lib/python3.8/site-packages/cf_xarray/data/cf-standard-name-table.xml'

@Zeitsperre
Copy link
Member Author

Zeitsperre commented Jan 31, 2023

The THREDDS issues have been resolved, cf-xarray fixes are on the way: xarray-contrib/cf-xarray#415. (EDIT: the bad cf-xarray version has just been yanked. Will perform a re-run of tests - should pass now).

I'm wondering though if we should allow the THREDDS-related tests to fail since they're service-dependent. What do you think?

@coveralls
Copy link

coveralls commented Jan 31, 2023

Coverage Status

coverage: 84.356%. first build
when pulling b5c6c0e on fix-geo-failures
into dd8d0ce on master.

@huard
Copy link
Collaborator

huard commented Feb 1, 2023

Is there a way to fail only if the service is not on ? If the service is available, but the test fails, I'd like to catch that.

@Zeitsperre
Copy link
Member Author

I can definitely look into that. If it's simple enough that I can add it here this morning, I'll add it. Otherwise, no more changes. As it stands, though, am I good to merge?

@Zeitsperre
Copy link
Member Author

Failing because of a new black. Opening another PR to fix this...

@Zeitsperre Zeitsperre merged commit 331c562 into master Feb 1, 2023
@Zeitsperre Zeitsperre deleted the fix-geo-failures branch February 1, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants