Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store Dataset in OutputReader class to avoid calling open_dataset repeatedly #289

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Store Dataset in OutputReader class to avoid calling open_dataset repeatedly #289

merged 2 commits into from
Jun 1, 2023

Conversation

huard
Copy link
Collaborator

@huard huard commented Jun 1, 2023

No description provided.

@huard huard requested a review from Zeitsperre June 1, 2023 15:33
Zeitsperre
Zeitsperre approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented Jun 1, 2023 •
edited
Loading

Coverage Status

coverage: 82.15%. first build
when pulling 7006e9a on fix-288
into c17976e on master.

@Zeitsperre Zeitsperre merged commit 7b9b55e into master Jun 1, 2023
@Zeitsperre Zeitsperre deleted the fix-288 branch June 1, 2023 16:15
@Zeitsperre Zeitsperre changed the title Store Dataset in OutputReader class to avoir calling open_dataset repeatedly Store Dataset in OutputReader class to avoid calling open_dataset repeatedly Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huard @coveralls @Zeitsperre