Prepare v0.12.3 #314
Merged
Prepare v0.12.3 #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Zeitsperre
commented
Oct 2, 2023
•
Zeitsperre
commented
Zeitsperre
force-pushed
the
prepare_v0124
branch
from
8961237
to
6858aea
Compare
huard
approved these changes
Oct 2, 2023
| @@ -375,6 +375,7 @@ | |||
|
|
|||
|
|
|||
| @pytest.mark.slow | |||
| @pytest.mark.xfail(reason="SpotPy Calibration is not entirely stable.") | |||
There was a problem hiding this comment.
This is quite weird though. What kind of instabilities are we talking about ?
There was a problem hiding this comment.
This is one of the tests that "sometimes" fails, regardless of build environment. There are a handful of tests that are not threadsafe, but because they kill the pytest workers when they fail, there's no way to mark them as xfailable.
There was a problem hiding this comment.
I wouldn't be surprised if the failures are due to the longstanding libnetcdf issues with asynchronous read of NetCDF4 files.
There was a problem hiding this comment.
Nevermind, it seems this test can also fail with a crash as well:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.