Prevent embedded Youtube videos from breaking in iOS #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mottie
added a commit
that referenced
this pull request
Jan 28, 2013
Prevent embedded Youtube videos from breaking in iOS
|
Thanks, that looks like a good addition! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Youtube's older embed code to add a video to my slideshow, the video plugin broke the video in iOS (tested on an iPhone and an iPad Mini). I fixed this by adding a quick check to make sure that the browser has support for at least FlashPlayer version 1 (iOS reports "0"). The plugin then only uses swfobject to embed content if Flash is supported by the browser.
I also removed the
? true : falseternary operator, because the expression should already evaluate to eithertrueorfalse. Let me know if I'm missing something.I re-minified the plugin using the YUI Compressor. Let me know if you'd prefer to have it minified some other way.