[CHERI][InstCombine] Fix 8-byte capability memcpy inlining #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrtc27
reviewed
May 14, 2024
| ; CHECK-NEXT: store ptr addrspace(200) [[TMP0]], ptr addrspace(200) [[D:%.*]], align 8 | ||
| ; CHECK-NEXT: ret ptr addrspace(200) [[D]] | ||
| ; | ||
| entry: |
| ; CHECK-NEXT: ret ptr addrspace(200) [[D]] | ||
| ; | ||
| entry: | ||
| ; memcpy can be transformed to capability load/store |
There was a problem hiding this comment.
Use ;; for non-FileCheck comments, and put at the top of the test function rather than buried inside it
| ret ptr addrspace(200) %d | ||
| } | ||
|
|
||
| ; Function Attrs: argmemonly mustprogress nocallback nofree nounwind willreturn |
There was a problem hiding this comment.
Useless comment from original IR dump
| } | ||
|
|
||
| ; Function Attrs: argmemonly mustprogress nocallback nofree nounwind willreturn | ||
| declare void @llvm.memcpy.p200.p200.i32(ptr addrspace(200) noalias nocapture writeonly, ptr addrspace(200) noalias nocapture readonly, i32, i1 immarg) addrspace(200) #1 |
There was a problem hiding this comment.
Even all these attributes should be removable, LLVM will add them automatically
jrtc27
reviewed
May 14, 2024
| ret ptr addrspace(200) %d | ||
| } | ||
|
|
||
| define ptr addrspace(200) @test_memcpy8_nocap_align_unkown(ptr addrspace(200) noundef %d, ptr addrspace(200) noundef %s) local_unnamed_addr addrspace(200) { |
StephenHuwClarke
force-pushed
the
stephen/fix-memcpy8
branch
from
6c428fe
to
a996ce3
Compare
|
Your second commit is authored by Stephen Clarke [email protected] but the first by Stephen Clarke [email protected] (and only the former seems associated with your GitHub account?). Otherwise looks good now thanks. |
StephenHuwClarke
force-pushed
the
stephen/fix-memcpy8
branch
from
a996ce3
to
735c067
Compare
arichardson
approved these changes
May 16, 2024
jrtc27
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivating case for this change is https://cheri-compiler-explorer.cl.cam.ac.uk/z/ore1Ej - the compiler is copying a capability using non-cap load and store. The issue is for copying 8-byte capabilities only, so won't affect targets with 16-byte capabilities e.g. rv64.