-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CBRD-25356] rename att_name in db_serial to attr_name #5346
Draft
vimkim
wants to merge
8
commits into
CUBRID:develop
Choose a base branch
from
vimkim:feature/rename_att_name_in_db_serial
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[CBRD-25356] rename att_name in db_serial to attr_name #5346
vimkim
wants to merge
8
commits into
CUBRID:develop
from
vimkim:feature/rename_att_name_in_db_serial
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hornetmj
approved these changes
Jul 22, 2024
vimkim
force-pushed
the
feature/rename_att_name_in_db_serial
branch
2 times, most recently
from
July 29, 2024 05:17
356fb38
to
3c048c3
Compare
모든 리뷰를 통과하는 도중에 따라서 현재 브랜치를 upstream/develop에 rebase했습니다. (git merge --ours와 동일합니다) |
vimkim
force-pushed
the
feature/rename_att_name_in_db_serial
branch
from
August 13, 2024 06:04
3c048c3
to
2dc573e
Compare
beyondykk9
approved these changes
Aug 19, 2024
This edit was suggested during the team meeting.
vimkim
force-pushed
the
feature/rename_att_name_in_db_serial
branch
from
August 19, 2024 10:10
2dc573e
to
a427378
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/CBRD-25356
문제점
att_name과 attr_name으로 서로 다르게 출력됩니다.
해결책
attr_name으로 통일했습니다.
;sc db_serial을 입력하면
위와 같이 결과가 바뀌게 됩니다.
참고
이 PR은 #5337 를 새로 만든 버전입니다.
기존 PR은 당시 입사 2주차인지라 사내 브랜치 권한에 대한 제한을 몰랐던 저의 잘못된 판단에 의해
upstream feature 브랜치에 직접 푸시되었으나,
feature 브랜치에 대한 rebase, --force-with-lease 등의 권한이 없다는 사실을 알게 되어
오류를 정정하고 fork repo로부터 pr을 새로 만들었습니다.
새로운 PR은 기존 PR에 표기된 @hornetmj 님의 리뷰를 모두 반영합니다.