Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated message factory #676

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tpazderka
Copy link
Collaborator

@tpazderka tpazderka commented Aug 2, 2019

  • Any changes relevant to users are recorded in the CHANGELOG.md.
  • The documentation has been updated, if necessary.
  • New code is annotated.
  • Changes are covered by tests.

@tpazderka tpazderka force-pushed the remove-message-factory branch 2 times, most recently from b5c1215 to 8914760 Compare August 2, 2019 18:18
@codecov-io
Copy link

codecov-io commented Aug 2, 2019

Codecov Report

Merging #676 into master will increase coverage by 0.23%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #676      +/-   ##
==========================================
+ Coverage   63.69%   63.93%   +0.23%     
==========================================
  Files          64       64              
  Lines       11826    11642     -184     
  Branches     2091     2053      -38     
==========================================
- Hits         7533     7443      -90     
+ Misses       3697     3626      -71     
+ Partials      596      573      -23
Impacted Files Coverage Δ
src/oic/extension/message.py 91.3% <ø> (+7.65%) ⬆️
src/oic/oauth2/message.py 74.06% <ø> (+0.34%) ⬆️
src/oic/oic/message.py 70.46% <100%> (+0.94%) ⬆️
src/oic/utils/settings.py 0% <0%> (-86.21%) ⬇️
src/oic/extension/client.py 38.57% <0%> (-0.47%) ⬇️
src/oic/utils/http_util.py 69.74% <0%> (-0.09%) ⬇️
src/oic/utils/rp/__init__.py 0% <0%> (ø) ⬆️
src/oic/oauth2/provider.py 71.16% <0%> (+0.37%) ⬆️
src/oic/oic/provider.py 74.6% <0%> (+0.41%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f55b996...3566526. Read the comment docs.

@tpazderka
Copy link
Collaborator Author

For some reason, the integration tests on this branch fail before they even start. This is not happening on any other PR although the travis config is the same in this respect...

I will have to investigate.

@tpazderka
Copy link
Collaborator Author

OK, the oidctest library relies on the removed factory, that is the reason for failures.

Will need to update the code and wait for merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants