Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a test component which involves testing the daylight saving si… #869

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shearichard-nec
Copy link

…tuation for a date in February. This test fails when the test is being run in those parts of southern hemisphere which use daylight saving.

  • Any changes relevant to users are recorded in the CHANGELOG.md.
  • [x ] The documentation has been updated, if necessary.
  • New code is annotated.
  • Changes are covered by tests.

…tuation for a date in February. This test fails when the test is being run in those parts of southern hemisphere which use daylight saving.
schlenk referenced this pull request Feb 27, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.80%. Comparing base (0e30cd2) to head (c641e1a).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #869      +/-   ##
==========================================
- Coverage   63.83%   63.80%   -0.04%     
==========================================
  Files          64       64              
  Lines       11879    11879              
  Branches     2107     2107              
==========================================
- Hits         7583     7579       -4     
- Misses       3693     3697       +4     
  Partials      603      603              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tpazderka tpazderka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rebase on current master? The CI should now pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants