Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to handheld profiles #115

Merged
merged 4 commits into from
Sep 22, 2024
Merged

Conversation

Pogogo007
Copy link
Contributor

@Pogogo007 Pogogo007 commented Jun 18, 2024

Also comment out kernel parameters as these will be managed by systemd-boot-manager in the future

@Pogogo007 Pogogo007 mentioned this pull request Jun 18, 2024
36 tasks
@Pogogo007 Pogogo007 marked this pull request as ready for review August 21, 2024 19:33
done
#kernelparams="amd_iommu=off amdgpu.gttsize=8128 spi_amd.speed_dev=1 audit=0 iomem=relaxed amdgpu.ppfeaturemask=0xffffffff"
#echo "Adding required kernel parameters..."
#sed -i "s/LINUX_OPTIONS=\"[^\"]*/& ${kernelparams}/" /etc/sdboot-manage.conf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using sed, you can create a file /etc/sdboot-manage.conf.d/10-chwd.conf and put the parameters in it:

LINUX_OPTIONS+=" amd_iommu=off amdgpu.gttsize=8128 spi_amd.speed_dev=1 audit=0 iomem=relaxed amdgpu.ppfeaturemask=0xffffffff"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is why the lines are commented out

@Pogogo007
Copy link
Contributor Author

Requires CachyOS/CachyOS-PKGBUILDS#300 to be merged and pushed beforehand

profiles/pci/handhelds/profiles.toml Outdated Show resolved Hide resolved
profiles/pci/handhelds/profiles.toml Outdated Show resolved Hide resolved
Copy link
Member

@vnepogodin vnepogodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vnepogodin vnepogodin merged commit 86516ea into CachyOS:master Sep 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants