Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Better Fast Leaves for Programmer Art #1862

Conversation

NebelNidas
Copy link
Contributor

@NebelNidas NebelNidas commented Jul 3, 2023

306f452, but for Programmer Art. I also copied the license file again just to be sure.

Before

2023-07-03_16 42 48

After

2023-07-03_16 04 07

Due to a bug in Fabric's Resource Loader (which I fixed today), this feature only works with Fabric API 0.85+; on previous versions it has no effect at all.

@NebelNidas NebelNidas changed the title Add Programmer Art Better Fast Leaves Add Better Fast Leaves for Programmer Art Jul 3, 2023
@NebelNidas
Copy link
Contributor Author

NebelNidas commented Jul 3, 2023

Hmm, the jungle leaves still look out of place, as if they haven't changed at all. Maybe the VanillaTweaks team accidentally bundled up an incorrect version? Doesn't seem implausible, since the modification dates are May of this year. Maybe you can ask them beforehand, @IMS212?

@jellysquid3 jellysquid3 added this to the Sodium 0.5 milestone Jul 5, 2023
@mrjasonn
Copy link

mrjasonn commented Jul 9, 2023

Please remember to make sure this is with vanilla parity because they seem to look a bit off @NebelNidas @jellysquid3

@NebelNidas
Copy link
Contributor Author

It unfortunately will never have a 100% visual parity to vanilla, since Sodium is interfering with leaf rendering ever since version 0.4.10. That's why I've made this PR in the first place, so it at least better resembles vanilla (take a look at my first screenshot, that's how it looks in the current release version)

@mrjasonn
Copy link

mrjasonn commented Jul 9, 2023

It unfortunately will never have a 100% visual parity to vanilla, since Sodium is interfering with leaf rendering ever since version 0.4.10. That's why I've made this PR in the first place, so it at least better resembles vanilla (take a look at my first screenshot, that's how it looks in the current release version)

@NebelNidas It is very important to have Sodium be wiith vanilla parity. If you haven't yet, please check in vanilla Minecraft and make sure the textures you are providing is with parity with the vanilla Programmer Art texture pack and I'd like to see it with vanilla parity and probably everyone else as well. Thanks!

@Fnige
Copy link

Fnige commented Jul 9, 2023

Honestly it looks close enough to vanilla parity for it to be fine

@mrjasonn
Copy link

Honestly it looks close enough to vanilla parity for it to be fine

Well it's still a vanilla parity issue so it deserves fixing.

@IMS212
Copy link
Member

IMS212 commented Jul 10, 2023

Sodium is not intended to have full vanilla parity, the texture change is required to fix this issue. I’ll ask if the textures are broken before merging.

@mrjasonn
Copy link

Sodium is not intended to have full vanilla parity, the texture change is required to fix this issue. I’ll ask if the textures are broken before merging.

Ok. Also please note we can use VanillaTweak's methods and make our own that resembles vanilla more @IMS212.

@mrjasonn
Copy link

mrjasonn commented Jul 11, 2023

And the Sodium Modrinth page says this:

Sodium is a free and open-source mod for Minecraft 1.16+ clients which greatly improves rendering performance while fixing some graphical issues. It boasts wide compatibility with the Fabric mod ecosystem when compared to other rendering-focused mods, and it does so without compromising on how the game looks, giving you that authentic block game feel.

This essentially means Sodium should have good enough vanilla parity. Especially with the Programmer Art pack, it shows the history of the game's textures. @IMS212

@IMS212 IMS212 self-requested a review July 17, 2023 13:45
Copy link
Member

@IMS212 IMS212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IMS212
Copy link
Member

IMS212 commented Jul 17, 2023

Actually, not sure... going to leave this for now while I confirm.

@IMS212
Copy link
Member

IMS212 commented Jul 22, 2023

Merged manually with a custom jungle leaves texture to fix VT's broken one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants