-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Better Fast Leaves for Programmer Art #1862
Add Better Fast Leaves for Programmer Art #1862
Conversation
Hmm, the jungle leaves still look out of place, as if they haven't changed at all. Maybe the VanillaTweaks team accidentally bundled up an incorrect version? Doesn't seem implausible, since the modification dates are May of this year. Maybe you can ask them beforehand, @IMS212? |
Please remember to make sure this is with vanilla parity because they seem to look a bit off @NebelNidas @jellysquid3 |
It unfortunately will never have a 100% visual parity to vanilla, since Sodium is interfering with leaf rendering ever since version 0.4.10. That's why I've made this PR in the first place, so it at least better resembles vanilla (take a look at my first screenshot, that's how it looks in the current release version) |
@NebelNidas It is very important to have Sodium be wiith vanilla parity. If you haven't yet, please check in vanilla Minecraft and make sure the textures you are providing is with parity with the vanilla Programmer Art texture pack and I'd like to see it with vanilla parity and probably everyone else as well. Thanks! |
Honestly it looks close enough to vanilla parity for it to be fine |
Well it's still a vanilla parity issue so it deserves fixing. |
Sodium is not intended to have full vanilla parity, the texture change is required to fix this issue. I’ll ask if the textures are broken before merging. |
Ok. Also please note we can use VanillaTweak's methods and make our own that resembles vanilla more @IMS212. |
And the Sodium Modrinth page says this:
This essentially means Sodium should have good enough vanilla parity. Especially with the Programmer Art pack, it shows the history of the game's textures. @IMS212 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Actually, not sure... going to leave this for now while I confirm. |
Merged manually with a custom jungle leaves texture to fix VT's broken one. |
306f452, but for Programmer Art. I also copied the license file again just to be sure.
Before
After
Due to a bug in Fabric's Resource Loader (which I fixed today), this feature only works with Fabric API 0.85+; on previous versions it has no effect at all.