Multiple misc changes to shader interfaces #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jellysquid3
reviewed
Aug 17, 2024
common/src/main/java/net/caffeinemc/mods/sodium/client/gl/shader/GlProgram.java
Outdated
Show resolved
Hide resolved
common/src/main/java/net/caffeinemc/mods/sodium/client/gl/shader/GlProgram.java
Outdated
Show resolved
Hide resolved
| @@ -46,6 +46,11 @@ public VertexSerializer get(VertexFormatDescription srcFormat, VertexFormatDescr | |||
| return serializer; | |||
| } | |||
|
|
|||
| @Override | |||
| public void registerSerializer(VertexFormatDescription srcFormat, VertexFormatDescription dstFormat, VertexSerializer serializer) { | |||
There was a problem hiding this comment.
I'm concerned about race conditions if Iris doesn't call into this early enough. But if it's handled in the client initializer, it's probably fine?
|
Fixed the two things; not sure if any changes should be made to the serializer portion, or if that can wait on b2. |
jellysquid3
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.