fix: Validate chunk section Y axis upon retrieving ChunkRenderContainer #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes CaffeineMC#587, the issue was present on CaffeineMC@de545a5. The `ChunkRenderManager#isChunkVisible` was modified using the new `ChunkGraphCuller#isSectionVisible` requiring a ChunkRenderContainer ID. Upon retrieving the `ChunkRenderContainer` with `ChunkRenderManager#getRender`, Sodium does not verify chunk section Y axis.
magneticflux-
suggested changes
Mar 17, 2021
| @@ -227,6 +227,10 @@ private void addEntitiesToRenderLists(ChunkRenderContainer render) { | |||
| } | |||
|
|
|||
| public ChunkRenderContainer getRender(int x, int y, int z) { | |||
| if (y < 0 || y >= 16) { | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
magneticflux-
approved these changes
Mar 17, 2021
jellysquid3
force-pushed
the
1.16.x/next
branch
from
12886a1
to
5545895
Compare
bytzo
pushed a commit
to bytzo/sodium-fabric
that referenced
this pull request
Jun 3, 2021
spoorn
pushed a commit
to spoorn/sodium-forge
that referenced
this pull request
Jun 30, 2021
IMS212
pushed a commit
to IMS212/sodium-fabric
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #587, the issue was present on de545a5. The
ChunkRenderManager#isChunkVisiblewas modified using the newChunkGraphCuller#isSectionVisiblerequiring a ChunkRenderContainer ID. Upon retrieving theChunkRenderContainerwithChunkRenderManager#getRender, Sodium does not verify chunk section Y axis.