Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing sign eip712 #202

Merged
merged 2 commits into from
Sep 19, 2024
Merged

fixing sign eip712 #202

merged 2 commits into from
Sep 19, 2024

Conversation

DiegoSena
Copy link
Collaborator

No description provided.

@ZzzzHui
Copy link
Collaborator

ZzzzHui commented Sep 13, 2024

I tested and nonodo didn't decode the msgSender and payload correctly. Can you show me your test result?

FYI, geth has library function to sign typed data. Please see here. And TypedData type is defined here
Usually it's best to use as much library as possible to avoid making mistakes. But I'm ok with implementing your own code if it's for experimentation purposes and the code runs correctly.

@ZzzzHui
Copy link
Collaborator

ZzzzHui commented Sep 13, 2024

Please rebase on main branch again. Thanks!

@sandhilt sandhilt mentioned this pull request Sep 19, 2024
Open
@DiegoSena DiegoSena changed the base branch from main to feature/avail September 19, 2024 20:33
@fabiooshiro fabiooshiro merged commit 9789ca0 into feature/avail Sep 19, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZzzzHui ZzzzHui Awaiting requested review from ZzzzHui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DiegoSena @ZzzzHui @fabiooshiro