Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COO-41 Add image labels #9

Merged
merged 2 commits into from
Oct 1, 2024
Merged

COO-41 Add image labels #9

merged 2 commits into from
Oct 1, 2024

Conversation

prkrtg
Copy link
Contributor

@prkrtg prkrtg commented Sep 19, 2024

Adds image labels for improved clarity in the GUI

Edit: New update now includes the file location of Image 1 and 2
The result label doesn't have a file location due to being in memory and the user has an option to write to disk if needed
Screenshot 2024-09-30 at 1 13 22 PM

Copy link

@scizen9 scizen9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest a unique identifier, like the filename, for the image labels. For ZMQ shared images, we may have to use some other identifier that would be in the metadata (header) like a serial number perhaps.

@prkrtg prkrtg requested a review from scizen9 September 30, 2024 20:14
Copy link

@scizen9 scizen9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unambiguous label so users will know exactly what image is displayed. Approve.

@prkrtg prkrtg merged commit 21df819 into main Oct 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants