Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add line numbers to the Threads & Variables panel #2780

Closed
Ashark opened this issue Oct 15, 2023 · 7 comments
Closed

Add line numbers to the Threads & Variables panel #2780

Ashark opened this issue Oct 15, 2023 · 7 comments
Labels
Debugger Enchancement
Milestone
2024.2.1

Comments

@Ashark
Copy link

Ashark commented Oct 15, 2023

Currently (Perl plugin 233.9102.97-EAP-SNAPSHOT), when debugging, in "Threads & Variables" panel, you can see stack lines. But they do not have line numbers at which the line is currently staying.
However, the debugger does apparently know that numbers, because it jumps there when I click.
It would be nice to see line numbers (like it is expected for any other language, for example for python in PyCharm).
@hurricup
Copy link
Collaborator

Yep, good point thank you. However it is possibly request to IDE part, not debugger backend. I'll investigate.

@hurricup
Copy link
Collaborator

Yep.

image

@hurricup hurricup transferred this issue from Camelcade/Devel-Camelcadedb Oct 15, 2023
@hurricup hurricup added this to the 2023.3 milestone Oct 15, 2023
hurricup added a commit that referenced this issue Oct 15, 2023
@hurricup
#2780 Added line number to the stack frame presentation
69c4973
hurricup added a commit that referenced this issue Oct 15, 2023
@hurricup
#2780 Added line number to the stack frame presentation
c4d6d76
hurricup added a commit that referenced this issue Oct 15, 2023
@hurricup
#2780 Fixed line numbering for the frames
a4f866c 
Perl provides us zero-based line numbers
hurricup added a commit that referenced this issue Oct 15, 2023
@hurricup
#2780 Fixed line numbering for the frames
5b4c452 
Perl provides us zero-based line numbers
hurricup added a commit that referenced this issue Oct 15, 2023
@hurricup
#2780 Fixed line numbering for the frames
0d093a5 
Perl provides us zero-based line numbers
@Ashark
Copy link
Author

Ashark commented Oct 15, 2023 •
edited
Loading

Ух ты! Спасибо за такой быстрый фикс! Поставил на eap версии.

@Ashark
Copy link
Author

Ashark commented Oct 23, 2023

I am not sure how correct it would be for perl, but could it be possible to also slightly improve the format?
As can be seen in screenshot for python debugger, the format is function, file:line. Can the perl debugger use the same? I.e., separate function name from package/file name? For example, the above frame could be written as:
_readConfigurationOptions, Application.pm:1234.

I have noticed that the format may differ per language. For example, here you can see it for php, and here for java.

@hurricup
Copy link
Collaborator

The problem is that it is not possible to show sub name and file path together so they both were visible. May be should show file name if sub is available. WIll think about it.

@hurricup hurricup modified the milestones: 2023.3, 2024.1 Jan 16, 2024
@hurricup hurricup modified the milestones: 2024.1, 2024.2 Apr 9, 2024
@hurricup hurricup removed this from the 2024.2 milestone Aug 18, 2024
@hurricup
Copy link
Collaborator

hurricup commented Sep 1, 2024 •
edited
Loading

Ended up with something like this:
image

image

image

@hurricup hurricup added this to the 2024.2.1 milestone Sep 1, 2024
hurricup added a commit that referenced this issue Sep 1, 2024
@hurricup
#2780 introduced method for splitting fqn to class and subname
b7d6b89
hurricup added a commit that referenced this issue Sep 1, 2024
@hurricup
#2780 adjusted logic for the stack frames naming
47ca784 
Now it is like:
file_path_or_sub_name:line_number[, namespace][ (file_path_if_sub_name_present)

Additionally several annotations/localizations issues fixed

Fixes #2780
hurricup added a commit that referenced this issue Sep 1, 2024
@hurricup
#2780 adjusted logic for the stack frames naming
9b71279 
Now it is like:
file_path_or_sub_name:line_number[, namespace][ (file_path_if_sub_name_present)

Additionally several annotations/localizations issues fixed

Fixes #2780
hurricup added a commit that referenced this issue Sep 1, 2024
@hurricup
#2780 introduced method for splitting fqn to class and subname
4e50fb6
@Ashark
Copy link
Author

Ashark commented Sep 1, 2024

Thanks!
I am not using the plugin currently, but hope it will be useful in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Debugger Enchancement
Projects
None yet
Milestone
2024.2.1
Development

No branches or pull requests
2 participants
@hurricup @Ashark