Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "perl5-IDEA" as a plugin archive name for releases #2789

Closed
Ashark opened this issue Nov 1, 2023 · 1 comment · Fixed by #2790
Closed

Use "perl5-IDEA" as a plugin archive name for releases #2789

Ashark opened this issue Nov 1, 2023 · 1 comment · Fixed by #2790
Milestone

Comments

@Ashark
Copy link

Ashark commented Nov 1, 2023

Hello.
Just a minor nitpick. Can you please give a meaningful name to the release archive in the JetBrains marketplace? Because currently, it is called just "plugin-233.9102.97-EAP-SNAPHOT.zip". When downloading manually, in the Downloads folder it is not obvious that it is a perl plugin. The other plugin developers name their archive with the name of plugin, you can see that for installed plugins "~/.local/share/JetBrains/<idename_version>/", for example "markdown-editor".
Probably, it is not possible to rename previous releases, but for new releases the "normal" archive name "Perl5-IDEA" can be used.

@hurricup
Copy link
Collaborator

hurricup commented Nov 1, 2023

The problem seems that jar is called same as a module it was built from. Usually plugins have a single module project and project name is used. Here we have a multi-module structure and plugin is build from :perl5:plugin module. I'll take a look, thanks.

hurricup added a commit that referenced this issue Nov 2, 2023
Module-based names are not always perfect. We now use `lang.xxx` as a base name for the artifact
hurricup added a commit that referenced this issue Nov 2, 2023
Module-based names are not always perfect. We now use `lang.xxx` as a base name for the artifact

Fixes #2789
@hurricup hurricup added this to the 2023.3 milestone Nov 2, 2023
hurricup added a commit that referenced this issue Nov 2, 2023
Module-based names are not always perfect. We now use `lang.xxx` as a base name for the artifact

Fixes #2789
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants