Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hurricup/exception fixes #2759

Merged
merged 13 commits into from
Sep 30, 2023
Merged

Hurricup/exception fixes #2759

merged 13 commits into from
Sep 30, 2023

Conversation

hurricup
Copy link
Collaborator

No description provided.

@hurricup
CAMELCADE-4087 do not run names cache for default project
b20c484 
#CAMELCADE-4087 Fixed
@hurricup
CAMELCADE-6220 do not create highlighter for invalid file
a3d3ab0 
Seems it happens sometimes, but I would expect platfrom to handle that

#CAMELCADE-6220 Fixed
@hurricup
#2664 introduced cpanminus module
40e3af3
@hurricup
#2664 moved install actions to the cpanminus module
f373d95
@hurricup
#2664 moved cpanfile type and import handler to the cpanminus module
f3bcb52 
There is some issue with quickdoc/resolve, see #2758
@hurricup
#2664 moved runAnything code to the cpanminus module
782e6d4 
We need to revisit it
@hurricup
#2664 renamed run anything providers to the more semantic
8deb4aa
@hurricup
#2664 migrated package adapters to the inversion of control
c5e5ed3
@hurricup
#2664 moved CpanminusAdapter to the cpanminus module
6a82b30
@hurricup
#2664 extracted PackageManagerAdapterFactory interface
20d8eaa
@hurricup
#2664 extracted cpan module with action and adapter
936ceee
@hurricup
#2664 Re-formatted code
c4d561a 
Formatting on commit was disabled for some reason
@hurricup hurricup enabled auto-merge (rebase) September 30, 2023 14:21
@github-actions
Copy link

github-actions bot commented Sep 30, 2023 •
edited
Loading

Qodana for JVM

2639 new problems were found

Inspection name Severity Problems
Usage of API marked for removal 🔴 Failure 14
Missorted modifiers 🔶 Warning 613
Unused declaration 🔶 Warning 597
Deprecated API usage 🔶 Warning 229
Missing '@Override' annotation 🔶 Warning 212
Method can be made 'void' 🔶 Warning 78
Check dependency licenses 🔶 Warning 65
Method parameter always has the same value 🔶 Warning 46
Method always returns the same value 🔶 Warning 38
Hardcoded strings 🔶 Warning 35
@NotNull/@Nullable problems 🔶 Warning 34
'size() == 0' can be replaced with 'isEmpty()' 🔶 Warning 27
Class is exposed outside of its visibility scope 🔶 Warning 25
Method is identical to its super method 🔶 Warning 21
Unnecessary semicolon 🔶 Warning 21
Declaration can have 'final' modifier 🔶 Warning 15
Can use bounded wildcard 🔶 Warning 14
Redundant 'throws' clause 🔶 Warning 11
Field may be 'final' 🔶 Warning 8
C-style array declaration 🔶 Warning 7
'final' method in 'final' class 🔶 Warning 3
Raw use of parameterized class 🔶 Warning 3
Incorrect string capitalization 🔶 Warning 2
Missing required 'lang' attribute 🔶 Warning 2
A service can be converted to a light one 🔶 Warning 2
Explicit type can be replaced with '<>' 🔶 Warning 1
Lambda can be replaced with method reference 🔶 Warning 1
'protected' member in 'final' class 🔶 Warning 1
Unnecessary conversion to 'String' 🔶 Warning 1
Unnecessary modifier 🔶 Warning 1
Duplicate branches in 'switch' ◽️ Notice 505
Method can be extracted ◽️ Notice 6
Immutable collection creation can be replaced with collection factory call ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Dependencies licenses

Third-party software list

This page lists the third-party software dependencies used in perl5

Dependency Version Licenses
annotations 24.0.0 Apache-2.0
ant-launcher 1.10.13 Apache-2.0
W3C-19980720
ant 1.10.13 Apache-2.0
W3C-19980720
clouds-docker-impl ideaiu-iu-232.8660.185-withsources Apache-2.0
copyright ideaic-ic-232.8660.185-withsources Apache-2.0
copyright ideaiu-iu-232.8660.185-withsources Apache-2.0
grammar-kit 2022.3.2 Apache-2.0
ideaic 2023.2 Apache-2.0
java-coverage ideaiu-iu-232.8660.185-withsources Apache-2.0
java ideaic-ic-232.8660.185-withsources Apache-2.0
jflex 1.9.2 BSD-3-Clause
jsr305 3.0.2 Apache-2.0
kotlin-stdlib-common 1.9.10 Apache-2.0
kotlin-stdlib-jdk7 1.9.10 Apache-2.0
kotlin-stdlib-jdk8 1.9.10 Apache-2.0
kotlin-stdlib 1.9.10 Apache-2.0
platform-langinjection ideaic-ic-232.8660.185-withsources Apache-2.0
platform-langinjection ideaiu-iu-232.8660.185-withsources Apache-2.0
remoterun ideaiu-iu-232.8660.185-withsources Apache-2.0
terminal ideaic-ic-232.8660.185-withsources Apache-2.0
terminal ideaiu-iu-232.8660.185-withsources Apache-2.0
webdeployment ideaiu-iu-232.8660.185-withsources Apache-2.0
Contact Qodana team

Contact us at [email protected]

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 30, 2023
View reviewed changes
plugin/cpanminus/build.gradle.kts
@@ -0,0 +1,25 @@
/*

Check warning

Code scanning / QDJVM

Check dependency licenses Warning

Transitive dependency: 'ant-launcher' ('1.10.13') 'W3C-19980720' is not in the allowed or the prohibited licenses lists with project license 'Apache-2.0'
plugin/cpan/build.gradle.kts
@@ -0,0 +1,25 @@
/*

Check warning

Code scanning / QDJVM

Check dependency licenses Warning

Transitive dependency: 'ant-launcher' ('1.10.13') 'W3C-19980720' is not in the allowed or the prohibited licenses lists with project license 'Apache-2.0'
plugin/cpan/build.gradle.kts
@@ -0,0 +1,25 @@
/*

Check warning

Code scanning / QDJVM

Check dependency licenses Warning

Transitive dependency: 'ant' ('1.10.13') 'W3C-19980720' is not in the allowed or the prohibited licenses lists with project license 'Apache-2.0'
plugin/cpanminus/build.gradle.kts
@@ -0,0 +1,25 @@
/*

Check warning

Code scanning / QDJVM

Check dependency licenses Warning

Transitive dependency: 'ant' ('1.10.13') 'W3C-19980720' is not in the allowed or the prohibited licenses lists with project license 'Apache-2.0'
...rc/main/java/com/perl5/lang/perl/cpanminus/runAnything/PerlCpanminusRunAnythingProvider.java
this("runAnything/cli/cpanm.xml");
}

protected PerlRunAnythingProvider(@NotNull String pathToConfig) {
protected PerlCpanminusRunAnythingProvider(@NotNull String pathToConfig) {

Check warning

Code scanning / QDJVM

Method parameter always has the same value Warning

Actual value of parameter pathToConfig is always 'runAnything/cli/cpanm.xml'
@hurricup hurricup merged commit 1a4c673 into master Sep 30, 2023
36 checks passed
@hurricup hurricup deleted the hurricup/exception-fixes branch September 30, 2023 16:43
@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 18 Code Smells

70.9% 70.9% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hurricup