Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2648 enabled pause debugging action #2832

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

hurricup
Copy link
Collaborator

Previously it was enabled by default, changed in JetBrains/intellij-community@e9a81e6

Intended behavior is - the button is always enabled to promote the feature, but if user presses it when action not available, he gets a notification with an explanation.

Fixes #2648

Previously it was enabled by default, changed in JetBrains/intellij-community@e9a81e6

Intended behavior is - the button is always enabled to promote the feature, but if user presses it when action not available, he gets a notification with an explanation.

Fixes #2648
@hurricup hurricup enabled auto-merge (rebase) February 26, 2024 08:29
Copy link

Qodana for JVM

2728 new problems were found

Inspection name Severity Problems
Usage of API marked for removal 🔴 Failure 24
Missorted modifiers 🔶 Warning 613
Unused declaration 🔶 Warning 596
Deprecated API usage 🔶 Warning 244
Missing '@Override' annotation 🔶 Warning 212
Method can be made 'void' 🔶 Warning 78
Check dependency licenses 🔶 Warning 77
Method parameter always has the same value 🔶 Warning 46
Method always returns the same value 🔶 Warning 38
@NotNull/@Nullable problems 🔶 Warning 36
Hardcoded strings 🔶 Warning 35
'size() == 0' can be replaced with 'isEmpty()' 🔶 Warning 27
Class is exposed outside of its visibility scope 🔶 Warning 25
Static initialization in extension point implementations 🔶 Warning 25
Method is identical to its super method 🔶 Warning 21
Unnecessary semicolon 🔶 Warning 21
Can use bounded wildcard 🔶 Warning 19
Declaration can have 'final' modifier 🔶 Warning 16
Non-platform TokenSet declared in ParserDefinition 🔶 Warning 16
Redundant 'throws' clause 🔶 Warning 13
Field may be 'final' 🔶 Warning 9
C-style array declaration 🔶 Warning 7
'final' method in 'final' class 🔶 Warning 3
Raw use of parameterized class 🔶 Warning 3
Incorrect string capitalization 🔶 Warning 2
Missing required 'lang' attribute 🔶 Warning 2
A service can be converted to a light one 🔶 Warning 2
Statement lambda can be replaced with expression lambda 🔶 Warning 1
Explicit type can be replaced with '<>' 🔶 Warning 1
Lambda can be replaced with method reference 🔶 Warning 1
Plugin.xml dynamic plugin verification 🔶 Warning 1
'protected' member in 'final' class 🔶 Warning 1
Unnecessary conversion to 'String' 🔶 Warning 1
Unnecessary modifier 🔶 Warning 1
Duplicate branches in 'switch' ◽️ Notice 505
Method can be extracted ◽️ Notice 5
Immutable collection creation can be replaced with collection factory call ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@hurricup hurricup merged commit cdfa777 into master Feb 26, 2024
37 checks passed
@hurricup hurricup deleted the hurricup/pause-debugging branch February 26, 2024 09:55
Copy link

sonarcloud bot commented Feb 26, 2024

@coveralls
Copy link

Coverage Status

coverage: 82.076% (-0.02%) from 82.1%
when pulling 469ad43 on hurricup/pause-debugging
into b1ece27 on master.

@astange1
Copy link

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interactive debugging UX is confusing (runtime pausing/bp setting)
3 participants