Use justfile instead of makefile #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldmedal
reviewed
Jun 7, 2024
Comment on lines
+75
to
+79
| - Install [poetry](https://github.com/python-poetry/poetry) with version 1.7.1: `curl -sSL https://install.python-poetry.org | python3 - --version 1.7.1` | ||
| - Install [casey/just](https://github.com/casey/just) | ||
| - Install [pre-commit](https://pre-commit.com) hooks: `just pre-commit-install` | ||
| - Execute `just install` to install the dependencies | ||
| - Execute `just test` to run the tests |
There was a problem hiding this comment.
Moving to just is a good improvement. However, there're many requirement tools before starting to develop this project. How about implementing a Makefile to install all of them?
There was a problem hiding this comment.
As discussed offline, we leave this issue for the user to decide how to install the requirements themselves.
goldmedal
approved these changes
Jun 7, 2024
|
Nice to know this tool, I will consider using it in the AI service as well. 🤙🤙🤙 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use casey/just for more features and modernization.