Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the to_one relationship and enhance the testing #613

Merged

Conversation

goldmedal
Copy link
Contributor

Changed

  • The to_one relationship is available now.
  • Ensure the generated plan is executable for DataFusion.
    • If table providers are registered, generate the DefaultTableSource for remote table sources.
    • If no, generate the LogicalTableSource for remote table sources. (It can't be executed by DataFusion)
  • Enhance the end to end testing

@@ -4,7 +4,7 @@
"models": [
{
"name": "customer",
"tableReference": "main.customer",
"tableReference": "customer",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the schema?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testing context, RemoteContextProvider, only register the table name without the schema. In this case, the table reference shouldn't have schema prefix.

@grieve54706 grieve54706 merged commit 95e768f into Canner:main Jun 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants