fix(trino): fix sql for querying metadata #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ibis
trino
python
goldmedal
reviewed
Oct 17, 2024
| @@ -38,7 +38,7 @@ def get_table_list(self) -> list[Table]: | |||
| AND t.table_name = c.table_name | |||
| INNER JOIN | |||
| system.metadata.table_comments AS tc | |||
| ON t.table_catalog = c.table_catalog | |||
| ON t.table_catalog = tc.catalog_name | |||
There was a problem hiding this comment.
I found this change isn't covered by the current tests. Even if I roll back the change, the Trino test is pass. I think it would be better if we provide a new test covering this change.
There was a problem hiding this comment.
Thanks for the heads up! I didn't realize this bug was only in the tpch.tiny.customer table. I'll update the test cases to reflect that.
goldmedal
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Thanks @grieve54706 I have double checked the test can cover this change. 👍
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #833