Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: CK_Multi recognized as multicomponent transport method in fl… #1069

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Bug fix: CK_Multi recognized as multicomponent transport method in fl… #1069

merged 1 commit into from
Jul 21, 2021

Conversation

lavdwall
Copy link
Contributor

This is a minor fix to make sure that the Chemkin-type multi-component transport type (CK_Multi) is treated properly by the 1D flame models.

Best regards,
Laurien

@codecov
Copy link

codecov bot commented Jul 11, 2021

Codecov Report

Merging #1069 (cb594ec) into main (1420a4c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1069   +/-   ##
=======================================
  Coverage   73.07%   73.07%           
=======================================
  Files         358      358           
  Lines       46956    46956           
=======================================
  Hits        34311    34311           
  Misses      12645    12645           
Impacted Files Coverage Δ
src/oneD/StFlow.cpp 90.09% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1420a4c...cb594ec. Read the comment docs.

@ischoegl
Copy link
Member

ischoegl commented Jul 21, 2021

@lavdwall ... thank you! The fix looks straight-forward. Per

virtual std::string transportType() const {
return (m_mode == CK_Mode) ? "CK_Multi" : "Multi";
}

there are two model names, with CK_Mode meaning Chemkin mode for the type of polynomial fits to temperature.

@ischoegl ischoegl merged commit 78f893f into Cantera:main Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants