Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RPATH related issues #1243

Merged
merged 3 commits into from
Apr 19, 2022
Merged

Fix RPATH related issues #1243

merged 3 commits into from
Apr 19, 2022

Conversation

speth
Copy link
Member

@speth speth commented Apr 16, 2022

Changes proposed in this pull request

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

This is especially helpful for the libcantera-devel Conda package and other cases
where the library isn't on a standard system path.
On Windows, when using Conda, site.getsitepackages() returns a list of
two directories, the first of which is the base of the conda installation.
Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@speth speth merged commit 67bac69 into Cantera:main Apr 19, 2022
@speth speth deleted the macos-rpath branch July 23, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants