-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Units] Add Cython interface for some functions #1285
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ischoegl
reviewed
May 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dove-tails nicely with #1076. I have one minor suggestion ...
ischoegl
reviewed
May 18, 2022
bryanwweber
force-pushed
the
add-units-helpers
branch
from
May 25, 2022 08:56
4d5d2d8
to
baeb7a4
Compare
ischoegl
reviewed
May 26, 2022
bryanwweber
force-pushed
the
add-units-helpers
branch
2 times, most recently
from
May 26, 2022 14:54
3284bc8
to
fe2dd53
Compare
These functions are chosen for their potential utility. Setting units is not enabled by this interface because it is meant to be handled internally. However, these methods can help to determine the unit factors for reaction rates.
bryanwweber
force-pushed
the
add-units-helpers
branch
from
May 26, 2022 15:11
fe2dd53
to
74f9419
Compare
ischoegl
reviewed
May 26, 2022
bryanwweber
force-pushed
the
add-units-helpers
branch
from
May 28, 2022 16:14
74f9419
to
cfc931e
Compare
ischoegl
reviewed
May 28, 2022
bryanwweber
force-pushed
the
add-units-helpers
branch
from
May 29, 2022 16:31
cfc931e
to
b599223
Compare
ischoegl
approved these changes
May 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you - LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions are chosen for their potential utility. Setting units is
not enabled by this interface because it is meant to be handled
internally. However, these methods can help to determine the unit
factors for reaction rates.