-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation warnings #1346
Fix compilation warnings #1346
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1346 +/- ##
=======================================
Coverage 68.15% 68.15%
=======================================
Files 327 327
Lines 42658 42659 +1
Branches 17180 17180
=======================================
+ Hits 29074 29075 +1
Misses 11291 11291
Partials 2293 2293
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
28c60c7
to
2dc89e9
Compare
2dc89e9
to
d28cf50
Compare
Alright - I fixed the warnings per discussion (together with two more I located, notably the mildly annoying Otherwise, I believe this is good to go from my side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d2364ca
to
8ed4a6f
Compare
@speth ... thanks for the review! I dropped the |
Changes proposed in this pull request
Fix compilation warnings caused by comparisons of
int
andsize_t
.Checklist
scons build
&scons test
) and unit tests address code coverage