Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yaml2ck man page #1365

Merged
merged 1 commit into from
Aug 13, 2022
Merged

yaml2ck man page #1365

merged 1 commit into from
Aug 13, 2022

Conversation

mefuller
Copy link
Contributor

@mefuller mefuller commented Aug 12, 2022

Changes proposed in this pull request

Add man page for yaml2ck (closes #1361)

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating the missing man file! I just noticed two minor things.

platform/posix/man/yaml2ck.1 Outdated Show resolved Hide resolved
platform/posix/man/yaml2ck.1 Outdated Show resolved Hide resolved
Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mefuller - this looks great ... I will merge as soon as the CI finishes.

@ischoegl ischoegl merged commit b9148b0 into Cantera:main Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

man page missing for yaml2ck
2 participants